Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move the renderer's LivenessScope into the context #222

Merged
merged 5 commits into from
Jan 26, 2024
Merged

fix: Move the renderer's LivenessScope into the context #222

merged 5 commits into from
Jan 26, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Jan 24, 2024 •
edited
Loading

Fixes #223

@niloc132 niloc132 changed the title Move the renderer's LivenessScope into the context fix: Move the renderer's LivenessScope into the context Jan 24, 2024
mofojed
mofojed requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks like a good change, cleans up the render context as well. Needs formatting applied

@niloc132 niloc132 marked this pull request as ready for review January 25, 2024 20:00
@niloc132 niloc132 requested a review from mofojed January 25, 2024 20:01
mofojed
mofojed previously approved these changes Jan 26, 2024
View reviewed changes
@niloc132 niloc132 requested a review from mofojed January 26, 2024 18:01
@niloc132 niloc132 merged commit 672aa43 into deephaven:main Jan 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

@mattrunyon mattrunyon Awaiting requested review from mattrunyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liveness objects created in hook functions (use_state, use_memo) break when re-rendering
2 participants
@niloc132 @mofojed