Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct formatting settings for ui.table #326

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Feb 28, 2024

  • Wasn't passing the settings into IrisGrid
  • Pull the settings from redux and pass them to IrisGrid
  • Fixes deephaven.ui default timestamp format #315
  • Verified using the steps in the ticket. The table uses the correct time zone.

- Wasn't passing the settings into `IrisGrid`
- Pull the settings from redux and pass them to `IrisGrid`
- Fixes deephaven#315
- Verified using the steps in the ticket. The table uses the correct time zone.
@mofojed mofojed requested a review from bmingles February 28, 2024 16:03
@mofojed mofojed self-assigned this Feb 28, 2024
@mofojed mofojed enabled auto-merge (squash) February 28, 2024 16:06
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mofojed mofojed merged commit 4762053 into deephaven:main Feb 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deephaven.ui default timestamp format
2 participants