-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export plotly-express as a dashboard plugin #329
Conversation
I think this will break plotly-express in DHC w/ dh.ui. We currently check if the plugin is the legacy format first when loading, so the legacy definition (named |
… named export next to the default WidgetPlugin
cb4dc26
to
e8ed513
Compare
I added a named export for the legacy |
): JSX.Element | null { | ||
const { id, layout, registerComponent } = props; | ||
|
||
const handlePanelOpen = useCallback( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note, we have a useDashboardPanel
hook that should do what we're doing here, but it would require other changes as well (since it doesn't use metadata
or fetch
at all). No need to worry about it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll actually want DHE to register both plugins. Otherwise plotly-express won't work in dh.ui in DHE
Why? What plugin type is needed for dh.ui in DHE? |
dh.ui reads the plugin registry and looks for |
But it should work with just the |
Yes once we support |
Tested with DHE V+ (1.20231218.176) Core 0.32.1
Closes #308
BREAKING CHANGE:
widget
type in thePanelEvent.OPEN
event arguments has changed fromVariableDefinition
toVariableDescriptor