docs: Fix the demo script #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some results were being assigned to a new variable instead of replacing the existing `result` panel - Add explicit wrapping around text with icon in ui.item case. Created ticket to automatically wrap raw nodes: deephaven#353 - Fix hist_demo. You cannot pass non-hashable objects into a set; in this case we were passing in a dict to the set of dependencies. Need to use an array instead - Should we even bother allow passing in a `set` because of stuff like this?
mattrunyon
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resultpanelItemcomponents are not implicitly wrapped inTextcomponents #353