-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tighten use_memo dependency types #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update the examples in DEMO.md
and examples/README.md
as well. There's a few cases in there using sets.
I did not see any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update DEMO.md
and examples/README.md
One example:
t = ui.use_memo(lambda: blink_to_append_only(blink_table), {blink_table})
There's a few from Colin's change: https://github.com/deephaven/deephaven-plugins/pull/291/files#diff-fb5877c1913d0ee5d0a6f0d1fa5f480d8b755dd04b95e3b74833ec0952a34d18
They're in there and need to be updated, I'd just search for {
and verify it's not a set being passed into a memo or effect.
Ah, that's where the demo file was. I still didn't find any in the examples file. |
Fixes #355
Only allow tuple and list, and throw if neither.