Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tighten use_memo dependency types #356

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

jnumainville
Copy link
Collaborator

Fixes #355
Only allow tuple and list, and throw if neither.

@jnumainville jnumainville changed the title fix: tighten deps fix: Tighten use_memo dependency types Mar 12, 2024
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the examples in DEMO.md and examples/README.md as well. There's a few cases in there using sets.

@jnumainville
Copy link
Collaborator Author

Make sure to update the examples in DEMO.md and examples/README.md as well. There's a few cases in there using sets.

I did not see any

@jnumainville jnumainville marked this pull request as ready for review March 12, 2024 21:29
@jnumainville jnumainville requested a review from mofojed March 12, 2024 21:29
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update DEMO.md and examples/README.md

One example:

    t = ui.use_memo(lambda: blink_to_append_only(blink_table), {blink_table})

There's a few from Colin's change: https://github.com/deephaven/deephaven-plugins/pull/291/files#diff-fb5877c1913d0ee5d0a6f0d1fa5f480d8b755dd04b95e3b74833ec0952a34d18

They're in there and need to be updated, I'd just search for { and verify it's not a set being passed into a memo or effect.

@jnumainville
Copy link
Collaborator Author

Ah, that's where the demo file was. I still didn't find any in the examples file.

@jnumainville jnumainville requested a review from mofojed March 13, 2024 14:14
@jnumainville jnumainville self-assigned this Mar 13, 2024
@jnumainville jnumainville merged commit 48dea18 into deephaven:main Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_memo should warn/throw if passed anything but an array for dependencies
2 participants