Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Python list_view implementation #359

Merged
merged 7 commits into from
Apr 3, 2024
Merged

feat: Add Python list_view implementation #359

merged 7 commits into from
Apr 3, 2024

Conversation

jnumainville
Copy link
Collaborator

fixes #337

Adds Python list_view implementation

@jnumainville jnumainville requested a review from mofojed March 14, 2024 16:07
@jnumainville jnumainville self-assigned this Mar 14, 2024
mofojed
mofojed requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should clear up how action_button is populated/used, then we should be good.
Will continue discussion about data sources in Slack team channel.

plugins/ui/src/deephaven/ui/components/list_view.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/list_view.py Outdated Show resolved Hide resolved
@jnumainville jnumainville requested a review from mofojed April 1, 2024 13:49
mofojed
mofojed requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minor doc spec fix. I think we should continue the discussion about item data source as well: #399
But doesn't need to hold this up.

plugins/ui/DESIGN.md Outdated Show resolved Hide resolved
plugins/ui/DESIGN.md Show resolved Hide resolved
@jnumainville @mofojed
Update plugins/ui/DESIGN.md
ac218b9 
Co-authored-by: Mike Bender <[email protected]>
@jnumainville jnumainville requested a review from mofojed April 3, 2024 14:51
@jnumainville jnumainville merged commit f0b8759 into deephaven:main Apr 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmingles bmingles bmingles left review comments

@mofojed mofojed mofojed approved these changes

Assignees

@jnumainville jnumainville

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.list_view python implementation
3 participants
@jnumainville @bmingles @mofojed