Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix build script to commit all files post version bump #363

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Mar 15, 2024

  • package.json files weren't being included in the commit, just commit everything
  • We can assume we're already at a clean slate in the post_package_bump
  • Move other JS plugins to use npm for the bump

- package.json files weren't being included in the commit, just commit everything
- We can assume we're already at a clean slate in the post_package_bump
@mofojed mofojed requested a review from JamesXNelson March 15, 2024 17:39
cog.toml Show resolved Hide resolved
tools/update_version.sh Show resolved Hide resolved
- Just ignore them in that case
- Log an error if a package is unrecognized
@mofojed mofojed self-assigned this Mar 19, 2024
@mofojed mofojed merged commit e064712 into deephaven:main Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants