chore: Upgraded @deephaven/jsapi-types to 1.0.0-dev0.33.2 (#389) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
commented
Mar 25, 2024
mofojed
requested changes
Mar 26, 2024
| @@ -22,7 +22,7 @@ function ObjectView(props: ObjectViewProps) { | |||
| () => | |||
| [...plugins.values()] | |||
| .filter(isWidgetPlugin) | |||
| .find(p => [p.supportedTypes].flat().includes(object.type)), | |||
| .find(p => [p.supportedTypes].flat().includes(object.type as string)), | |||
There was a problem hiding this comment.
Instead of casting here... Above I'd just set type and then just check if it's null before going through plugins (since we will never be able to open the object if the type isn't defined). Also there's a object == null check that doesn't make sense below (since it's always defined).
So something like :
const { object } = props;
const { type } = object;
...
const plugin = useMemo(
() =>
type != null ? [...plugins.values()]
.filter(isWidgetPlugin)
.find(p => [p.supportedTypes].flat().includes(type)) : undefined,
[plugins, type]
);
Comment on lines
17
to
24
|
|
||
| const Component = getSpectrumComponent(name) as | ||
| | React.ComponentType<unknown> | ||
| | undefined; | ||
|
|
||
| if (Component == null) { | ||
| throw new Error(`Unknown Spectrum component ${name}`); | ||
| } |
There was a problem hiding this comment.
Instead of this, we should throw in getSpectrumComponent if there is no type returned. Then this is just const Component = getSpectrumComponent(name) and it all makes sense.
Comment on lines
31
to
33
| const openedMetadataRef = useRef<ReactPanelControl['metadata'] | null>( | ||
| portal != null ? metadata : null | ||
| ); |
There was a problem hiding this comment.
Ahhh good catch. I would've just returned undefined instead of null, since that matches the ReactPanelControl['metadata'] type already.:
Suggested change
| const openedMetadataRef = useRef<ReactPanelControl['metadata'] | null>( | |
| portal != null ? metadata : null | |
| ); | |
| const openedMetadataRef = useRef<ReactPanelControl['metadata']>( | |
| portal != null ? metadata : undefined | |
| ); |
mofojed
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #389