docs: Combo box spec #392
Merged
docs: Combo box spec #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
reviewed
Mar 28, 2024
dsmmcken
reviewed
Mar 28, 2024
bmingles
reviewed
Apr 1, 2024
bmingles
reviewed
Apr 1, 2024
dsmmcken
reviewed
Apr 3, 2024
mofojed
requested changes
Apr 3, 2024
mofojed
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #391
Since a combo box is essentially a picker, this is identical to the picker spec with the exception of a
search_typemodeled off of the functionality provided by React Spectrum's useFilter hookI know there are more collator options, but I'm unsure how necessary they are at this time, and if they are perhaps we need another object like
ui.search_optionsto handle that