Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: python date picker implementation #409

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

jnumainville
Copy link
Collaborator

fixes #368
Implements the python side of date picking, including converting all date props to Java date types and wrapping the callback function with the appropriate conversion.

@jnumainville jnumainville changed the title feature: python date picker implementation feat: python date picker implementation Apr 11, 2024
@jnumainville jnumainville marked this pull request as draft April 11, 2024 21:12
@jnumainville
Copy link
Collaborator Author

Pulled back to draft because I need to do some memoization here. Don't want unavailable_dates recalculated when only value changes, for example.

@jnumainville jnumainville marked this pull request as ready for review April 11, 2024 22:12
plugins/ui/src/deephaven/ui/_internal/utils.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/_internal/utils.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/_internal/utils.py Outdated Show resolved Hide resolved
@jnumainville jnumainville merged commit 5ed66a7 into deephaven:main Apr 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.date_picker Python side implementation
3 participants