-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement python item_table_source #415
feat: Implement python item_table_source #415
Conversation
@mofojed I'm wondering if it actually makes sense to make this a "Python side only" concept. There's not anything really "UI" related. The dictionary could just be merged into the props on component creation. |
I went ahead and did the unpacking
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we should also add to the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, will need to merge latest and fix conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to clean up the example doc a little bit.
Fixes #414
Adds Python side of
item_table_source
and required refactoring.