fix: Memoize use_table_data listener #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the listener function was not memoized in
use_table_data
, theuse_effect
withinuse_table_listener
was getting called unnecessarily, which means in some cases table updates can be missed during the start and stop of the listener.Added fix and caution message in
use_table_listener
for now.It might be worthwhile making
use_table_listener
more robust in cases where arguments changed, but the table specifically did not. This is not trivial though.