Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip running e2e for docs only changes #432

Closed
wants to merge 1 commit into from

Conversation

dsmmcken
Copy link
Contributor

Adds a path-ignore for files within /docs folders and .md files anywhere

@dsmmcken dsmmcken requested a review from mofojed April 24, 2024 16:23
@dsmmcken dsmmcken changed the title tests: skip running e2e for docs only changes ci: skip running e2e for docs only changes Apr 24, 2024
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the action to still pass for CI

@dsmmcken dsmmcken enabled auto-merge (squash) April 26, 2024 20:30
Comment on lines +8 to +10
paths-ignore:
- '**/docs/**'
- '**.md'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsmmcken: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Warning: If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.
If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see "Using conditions to control job execution."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems annoyingly difficult to do. Just going to close this PR.

@dsmmcken dsmmcken closed this Apr 26, 2024
auto-merge was automatically disabled April 26, 2024 21:27

Pull request was closed

@dsmmcken
Copy link
Contributor Author

This seems annoyingly difficult to do

@dsmmcken dsmmcken deleted the dmckenzie_exclude_e2e_from_docs_only_actions branch April 26, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants