Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip running e2e for docs only changes #432

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@ on:
branches:
- main
- 'release/**'
paths-ignore:
- '**/docs/**'
- '**.md'
Comment on lines +8 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsmmcken: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Warning: If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.
If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see "Using conditions to control job execution."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems annoyingly difficult to do. Just going to close this PR.

pull_request:
branches:
- main
- 'release/**'
paths-ignore:
- '**/docs/**'
- '**.md'

jobs:
e2e-test:
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@v4

- name: Run tests
run: "./tools/run_docker.sh e2e-tests"
run: './tools/run_docker.sh e2e-tests'

- name: Upload Playwright report
uses: actions/upload-artifact@v4
Expand All @@ -34,10 +40,10 @@ jobs:
- name: Dump server logs
if: failure()
run: docker logs deephaven-plugins > /tmp/server-log.txt

- name: Upload server logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: server-logs
path: /tmp/server-log.txt
path: /tmp/server-log.txt
Loading