Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix stale e2e server image locally #454

Merged
merged 2 commits into from
May 8, 2024

Conversation

mattrunyon
Copy link
Collaborator

Fixed an issue that caused the server edge image to be stale when running locally
Added a few lines from web-client-ui to install fonts in the Dockerfile just in case they're needed
Generated new snapshots from fira font change
Removed a package.json script that didn't work
Removed an env variable we weren't actually using for e2e tests

@mattrunyon mattrunyon requested a review from bmingles May 8, 2024 19:33
@mattrunyon mattrunyon self-assigned this May 8, 2024
@mattrunyon mattrunyon enabled auto-merge (squash) May 8, 2024 19:35
tests/Dockerfile Outdated Show resolved Hide resolved
@mattrunyon mattrunyon disabled auto-merge May 8, 2024 19:36
bmingles
bmingles previously approved these changes May 8, 2024
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrunyon mattrunyon requested review from bmingles and dsmmcken May 8, 2024 19:37
@mattrunyon mattrunyon enabled auto-merge (squash) May 8, 2024 19:37
@mattrunyon mattrunyon merged commit 19d6cd6 into deephaven:main May 8, 2024
9 checks passed
@mattrunyon mattrunyon deleted the e2e-fix branch May 8, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants