fix: Reset state when new instance of widget created #486

mofojed · 2024-05-22T15:45:34Z

We were using the same initial data regardless of how long the widget was opened
We want to keep the same WidgetHandler and panelIds so that panels open in the same spot
Want to start with a fresh state
Freeze the initialData whenever the fetched widget is updated
Fixes Recreating UI components resets their state to when the page loaded instead of a clean state #401
Tested using the steps in the description

- We were using the same initial data regardless of how long the widget was opened - We want to keep the same WidgetHandler and panelIds so that panels open in the same spot - Want to start with a fresh state - Freeze the initialData whenever the fetched widget is updated - Fixes deephaven#401 - Tested using the steps in the description

plugins/ui/src/js/src/widget/WidgetHandler.tsx

plugins/ui/src/js/src/widget/WidgetHandler.test.tsx

bmingles · 2024-05-23T15:04:06Z

plugins/ui/src/js/src/widget/WidgetHandler.test.tsx

+  rerender(
+    makeWidgetHandler({
+      widget: widget2,
+      fetch: fetch2,


Is the change to fetch what you want to test here or just the change to widget?

The descriptor. I'll have another PR up shortly that will negate the need to pass in fetch entirely.

plugins/ui/src/js/src/widget/WidgetHandler.test.tsx

bmingles

App code change looks good. Left a couple of comments / questions on the test

plugins/ui/src/js/src/widget/WidgetTestUtils.ts

- Create utility functions to make tests more readable - Clean up some comments

plugins/ui/src/js/src/widget/WidgetHandler.test.tsx

- Refactor some of the tests with a new utility function to be more readable

bmingles

LGTM

mofojed requested a review from bmingles May 22, 2024 15:45

mofojed self-assigned this May 22, 2024