Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: item #531

Merged
merged 8 commits into from
Jun 25, 2024
Merged

docs: item #531

merged 8 commits into from
Jun 25, 2024

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Jun 8, 2024

Closes #496

https://github.com/adobe/react-spectrum/blob/main/packages/%40react-types/shared/src/collections.d.ts
Only added docs from ItemProps. Not sure if I needed to add props from Node interface as well

Also wanted to verify the expected behaviour for the title prop. In something like a picker component, the title of an item renders rather than the children passed in if defined. This made sense to me just wanted to make sure it's the behaviour desired.

Sample code:

import deephaven.ui as ui

# simple picker that takes ui.items and is uncontrolled
picker1 = ui.picker(
    ui.item("Option 1", has_child_items=True,title="test"),
    ui.item("Option 2"),
    ui.item("Option 3"),
    ui.item("Option 4"),
    default_selected_key="Option 2"
)
image

@ethanalvizo ethanalvizo self-assigned this Jun 8, 2024
@ethanalvizo ethanalvizo marked this pull request as ready for review June 11, 2024 01:29
@ethanalvizo ethanalvizo requested a review from mofojed June 11, 2024 01:29
@ethanalvizo ethanalvizo requested a review from mofojed June 21, 2024 14:19
@ethanalvizo ethanalvizo requested a review from mofojed June 24, 2024 13:49
@ethanalvizo ethanalvizo merged commit 21fe131 into deephaven:main Jun 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydocs for item
2 participants