Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Date Field Implementation #804

Merged
merged 12 commits into from
Sep 5, 2024
Merged

feat: Date Field Implementation #804

merged 12 commits into from
Sep 5, 2024

Conversation

dgodinez-dh
Copy link
Contributor

Closes #648

@dgodinez-dh dgodinez-dh requested a review from bmingles September 5, 2024 15:58
@dgodinez-dh dgodinez-dh requested review from mofojed and removed request for bmingles September 5, 2024 15:59
@dgodinez-dh dgodinez-dh changed the title Date Field Implementation feat: Date Field Implementation Sep 5, 2024
margaretkennedy
margaretkennedy reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@margaretkennedy margaretkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few small typos I seemed to have missed in my original read.

@dgodinez-dh dgodinez-dh merged commit 9a72d2d into deephaven:main Sep 5, 2024
17 checks passed
@dgodinez-dh dgodinez-dh deleted the dag_DateField branch September 5, 2024 17:29
@mofojed mofojed mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaretkennedy margaretkennedy margaretkennedy left review comments

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.date_field input
3 participants
@dgodinez-dh @mofojed @margaretkennedy