Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: dashboard #814
docs: dashboard #814
Changes from all commits
dfe9b57
491495b
8f68a4f
bdb2f6d
e7e9de8
ebabf37
fd05e66
0d02a62
d9775e2
fe44d62
141520b
8b120b7
bbd470e
9663d9b
95353ad
d530e8b
e59ec3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add autodoc string.
Should we auto doc row, column, stack and panel all on this page? @mattrunyon @mofojed @jnumainville ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added but leaving unresolved so others can see comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsmmcken I think we should document row/column/stack here, as it doesn't make sense outside of the dashboard context. Precedent would be similar to
Radio
in the Spectrum docs, as it doesn't make sense outside ofRadioGroup
so they document it there: https://react-spectrum.adobe.com/react-spectrum/RadioGroup.html#radio-propsI could see
panel
being separate since you can create a panel without a dashboard.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use row and column within a panel currently. They are basically an alias for flex row and flex column, but they don't have the other props of flex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, panel gets it's own page, but row/col/stack can go under this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mention in the flex page that row/column are aliases for
flex(..., direction='row')
andflex(..., direction='column')
when used within a panel? You can't adjust things like flex-wrap or align-items, but they are meant to be simple versions of flexThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made note of this in the current flex docs PR to wait until this discussion is resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate panel docs captured in #922