docs: ui.action_group #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmmcken
reviewed
Sep 20, 2024
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
…e/deephaven-plugins into 829_action_group_docs
AkshatJawne
commented
Sep 20, 2024
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
AkshatJawne
commented
Sep 21, 2024
Three grammar edits
margaretkennedy
previously approved these changes
Sep 21, 2024
dsmmcken
requested changes
Sep 24, 2024
Co-authored-by: Don <[email protected]>
| ) | ||
| ``` | ||
|
|
||
| The `button_label_behavior` prop can be set to "hide" label text within buttons and show it in a tooltip on hover. |
There was a problem hiding this comment.
What about:
Suggested change
| The `button_label_behavior` prop can be set to "hide" label text within buttons and show it in a tooltip on hover. | |
| Use the `button_label_behavior` prop to "hide" label text within buttons and show it in a tooltip on hover. |
Are there other options?
There was a problem hiding this comment.
It can be set "show", "collapse", and "hide", but usually, users would only be setting it to "hide"
There was a problem hiding this comment.
@dsmmcken worth mentioning? I assume show is the default?
There was a problem hiding this comment.
Just hide is fine, I have no preference on how you guys word it.
…e/deephaven-plugins into 829_action_group_docs
dsmmcken
requested changes
Sep 30, 2024
dsmmcken
requested changes
Oct 1, 2024
dsmmcken
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829