feat: allow overflow by default on ui.panel #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
previously approved these changes
Sep 20, 2024
mattrunyon
requested changes
Sep 20, 2024
|
Edited to also address #544 |
mofojed
approved these changes
Sep 26, 2024
mattrunyon
approved these changes
Sep 26, 2024
wusteven815
added a commit
to wusteven815/deephaven-plugins
that referenced
this pull request
Oct 1, 2024
commit 94206d8 Author: Steven Wu <[email protected]> Date: Tue Oct 1 11:29:19 2024 -0400 fix: text_field events throw error (deephaven#913) - Fixes deephaven#893 - Generalize the text area hook to be used for any text input, and make `text_field` use that commit 47ed09b Author: Brian Ingles <[email protected]> Date: Mon Sep 30 17:12:52 2024 -0500 chore: Update dh packages to ^0.95.0 (deephaven#916) Update dh packages to ^0.95.0 resolves deephaven#914 commit 5b0dce6 Author: Don <[email protected]> Date: Mon Sep 30 12:34:59 2024 -0400 chore: remove errant comments (deephaven#915) Remove some accidental TODO comments that slipped in with a previous review commit 5fb0ed5 Author: ethanalvizo <[email protected]> Date: Fri Sep 27 12:44:35 2024 -0400 docs: flex pydocs (deephaven#912) Closes deephaven#824 Separated from markdown docs in other flex [PR](deephaven#785) commit 42315cf Author: Matthew Runyon <[email protected]> Date: Fri Sep 27 11:42:07 2024 -0500 feat: Dataclass serialization support for deephaven UI (deephaven#897) Fixes deephaven#757 I tested manually by creating my own dataclass with this code ```py import dataclasses @dataclasses.dataclass class Databar: column: str color: list[str] | None = None from deephaven import time_table, ui _t = time_table("PT1S").update(["X=ii", "Y=X", "Z=X", "A=X", "B=X", "C=X", "HalfX=X/2", "LogX=X > 0 ? log(X) : 0", "X2=X*2"]) t = ui.table(_t, databars=[ Databar(column="B"), ]) ``` commit df5b17c Author: Don <[email protected]> Date: Thu Sep 26 17:09:09 2024 -0400 feat: allow overflow by default on ui.panel (deephaven#896) Fixes deephaven#178 This improves the default layout experience across a number of layout cases. The primary goal was to allow overflow auto to happen on ui.panel by default while still filling space when passing multiple objects such as tables and plots. Tested across the cases in ui_flex.py, added e2e tests for those cases. Changes are as follows: - ui.panel has an overflow property, and defaults to auto - ui.grid now has default gap and flex auto - iris-grid has a min height of 70px to improve cases where it would normally shrink to 0 - ui panel continues to wrap children by default in a flex with align start, but immediate flex children and grid have align-self stretch which is the normal default of a flex element - iris grid canvas has position absolute set so it doesn't actually impact flow BREAKING CHANGE: ui.panel now has overflow auto set by default and ui.grid now has default padding commit 894dbc0 Author: Steven Wu <[email protected]> Date: Thu Sep 26 11:28:58 2024 -0400 fix: dynamically update panel title (deephaven#906) - Fixes deephaven#318 - Store the previous title to check if an update is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
This improves the default layout experience across a number of layout cases. The primary goal was to allow overflow auto to happen on ui.panel by default while still filling space when passing multiple objects such as tables and plots.
Tested across the cases in ui_flex.py, added e2e tests for those cases.
Changes are as follows:
BREAKING CHANGE: ui.panel now has overflow auto set by default and ui.grid now has default padding