Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dx now respects the webgl flag #934

Merged
merged 19 commits into from
Nov 23, 2024
Prev Previous commit
Next Next commit
wip
jnumainville committed Oct 24, 2024
commit 5fe29ec6340d56849bc4931d8982d581f4343d1e
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/plotly-express/src/js/package.json
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@
"update-dh-packages": "node ../../../../tools/update-dh-packages.mjs"
},
"devDependencies": {
"@deephaven/jsapi-types": "1.0.0-dev0.35.2",
"@deephaven/jsapi-types": "1.0.0-dev0.36.1",
"@deephaven/test-utils": "0.97.0",
"@types/deep-equal": "^1.0.1",
"@types/plotly.js": "^2.12.18",
7 changes: 6 additions & 1 deletion plugins/plotly-express/src/js/src/PlotlyExpressChartUtils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import type { Data, LayoutAxis, PlotlyDataLayoutConfig, PlotType } from 'plotly.js';
import type {
Data,
LayoutAxis,
PlotlyDataLayoutConfig,
PlotType,
} from 'plotly.js';
import type { dh as DhType } from '@deephaven/jsapi-types';

/**

Unchanged files with check annotations Beta

);
});
it('should swap replaceable WebGL traces without blocker events if WebGL is disabled or reenabled', async () => {

Check failure on line 266 in plugins/plotly-express/src/js/src/PlotlyExpressChartModel.test.ts

GitHub Actions / test-js / unit

Delete `·`

Check failure on line 266 in plugins/plotly-express/src/js/src/PlotlyExpressChartModel.test.ts

GitHub Actions / test-js / unit

Delete `·`
const mockWidget = createMockWidget([SMALL_TABLE], 'scattergl');
const chartModel = new PlotlyExpressChartModel(
mockDh,