Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring_parser 0.16 #122

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Add docstring_parser 0.16 #122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1cca0
add docstring_parser
wusteven815 Oct 4, 2024
bbf33c8
change version to be >=0.16
wusteven815 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contexts/server-base/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ java-utilities

# optional autocomplete feature
jedi==0.19.1
docstring_parser==0.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically prefer to be more lenient with our "requirements"; jedi is a special case where we have seen bad things happen with different versions, it's the only version we pin in py/server/setup.py. Do you have reason to believe that earlier versions of docstring_parer won't work? Or, that future versions of docstring_parser will be incompatible? If not, it would be preferable to not set a version (or, if you know old versions don't work, set a minimum version).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it to be >=0.16. I'm using a feature that's new in this version and there's no reason to believe that future versions would be incompatible.


# optional adbc feature
adbc-driver-manager
Expand Down