refactor: Split out packages #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
force-pushed
the
116-2-panel-management
branch
3 times, most recently
from
aed8676 to
2a1dc80
Compare
bmingles
force-pushed
the
79-1-packages-dir
branch
from
d6f7b3a to
bbd0962
Compare
End-to-end Test Summary
Detailed Test Results
Failed Test SummaryNo failed tests ✨Flaky Test SummaryNo flaky tests detected. ✨ |
mofojed
approved these changes
Sep 20, 2024
| @@ -3,14 +3,17 @@ _ignore/** | |||
| .vscode/** | |||
| .vscode-test/** | |||
| src/** | |||
| packages/** | |||
There was a problem hiding this comment.
I wonder if instead of a vscodeignore we should only be including certain paths? Seems like we're excluding a lot more than we're including, and we need to exclude more stuff everytime we add new things.
Also I'd add a .venv here - I sometimes create a venv when testing this stuff, and then packaging takes forever if I forget I did that.
There was a problem hiding this comment.
Just now saw this comment. I'll look into these things. Curious if there's a whitelist approach instead of ignore.
| * to `out/tmp` as `.cjs` files (renaming of import / export to cjs compatible code). | ||
| * 2. requires `dh-core.mjs` and return the default export. | ||
| * Copy / modified from https://github.com/deephaven/deephaven.io/blob/main/tools/run-examples/includeAPI.mjs | ||
| * NOTE: there is a limitation in current vscode extension apis such that es6 imports are not supported. This is why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscodeThe new
packagesdirectory provides a better silo for temporary code that will eventually become proper npm packages. e.g. enterprise jsapi types will be put in here on subsequent PR. Should also help with early dev of deephaven/deephaven-core#5537