Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-18191 esbuild cross os #193

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix: DH-18191 esbuild cross os #193

merged 3 commits into from
Dec 18, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Dec 16, 2024

DH-18191 Fixed issue with extension not working on Windows due to embedded esbuild OS specific dependency. Swapped to esbuild-wasm.

Copy link

github-actions bot commented Dec 16, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:00:23
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1951
should return custom settings: Empty configspassed ✅300
should return custom settings: Populated configspassed ✅102
should be able to load VSCodepassed ✅1128
should only be visible when a supported file type is active: test.groovypassed ✅2804
should only be visible when a supported file type is active: test.pypassed ✅1179
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles marked this pull request as ready for review December 16, 2024 15:30
@bmingles bmingles marked this pull request as draft December 16, 2024 15:32
@bmingles bmingles marked this pull request as ready for review December 18, 2024 17:23
@bmingles bmingles requested a review from mofojed December 18, 2024 17:23
@bmingles bmingles merged commit 5d6a8f0 into main Dec 18, 2024
4 checks passed
@bmingles bmingles deleted the DH-18191_esbuild-cross-os branch December 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants