Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed bug with new panels not always showing initial content #200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Jan 7, 2025

DH-18347: Fixed bug with new panels not always showing initial content

Testing

from deephaven import time_table

t1 = time_table("PT2S")

t2 = time_table("PT2S")
  1. Run the script 1x
  2. Close panel for t1
  3. Re-run the script
  4. Select t2 tab
  5. Should see ticking table in t2. Before bug fix, this panel was empty

Regression tests

  1. Close all panels
  2. Open t1 then t2 from "PANELS" tree view. Both should have ticking tables

Copy link

github-actions bot commented Jan 7, 2025

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:27:02
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅2127
should return custom settings: Empty configspassed ✅213
should return custom settings: Populated configspassed ✅148
should be able to load VSCodepassed ✅1232
should only be visible when a supported file type is active: test.groovypassed ✅2941
should only be visible when a supported file type is active: test.pypassed ✅1309
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles requested a review from mofojed January 7, 2025 19:51
// `subscribeToFieldUpdates` handler in DhcService which issues a
// `REFRESH_VARIABLE_PANELS_CMD` command for variables matching existing
// panels.
// 2. Newly created panels that are not the initially active panel (aka. any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is missing the case where the newly created panel is not the initially active panel but it is already visible:
image

This can happen with the example you provided.
Steps to Reproduce:

  1. Run the snippet creating t1 and t2
  2. Move both panels to a separate tab stack than the code
  3. Close t1
  4. Run the code snippet again

Expected Results
4. t2 should refresh in the location it's in, t1 should open up and load if visible

Actual Results
4. t2 becomes active but t1 shows up as a blank panel. Once selected it becomes visible.

I think there's a follow up here as well, since what I really expect is all the panels to open in the same stack. It's weird/annoying to have the panel open up in the same stack as the code, since now my Editor is blocked. I'd rather it would open all the panels in a new stack on the first run, and on subsequent runs open in the same panel if they already exist, or the same stack as one of the panels that already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants