Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Pre-release publish vscode extension #26

Merged
merged 10 commits into from
Jul 12, 2024
Merged

build: Pre-release publish vscode extension #26

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
97514d0
Added icon and background color for vscode gallery (#18)
bmingles Jul 10, 2024
e9f8140
Pre-release 0.1.0 + README (#18)
bmingles Jul 10, 2024
e4ebc05
Light logo (#18)
bmingles Jul 11, 2024
f7725b6
Notes on publishing (#18)
bmingles Jul 11, 2024
93e6775
Fixing theme in marketplace (#18)
bmingles Jul 11, 2024
92da0ec
Version bump for publish (#18)
bmingles Jul 11, 2024
9638887
Split out a CONTRIBUTING doc (#18)
bmingles Jul 11, 2024
ea09fa4
Version bump to update marketplace README (#18)
bmingles Jul 11, 2024
d1c4956
Fixed docs per review comment (#18)
bmingles Jul 12, 2024
4d438d2
Updated docs per review comment. (#18)
bmingles Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@ On subsequent script runs, the session will be re-used and only steps 4 and 5 wi

The extension dynamically downloads and loads the DH JS API from a running DH Core server.

- `src/jsApi.downloadDhFromServer()`
At runtime, `dh-internal.js` and `dh-core.js` are downloaded from the running DH server (default http://localhost:10000). The files are saved to `out/tmp` as `.cjs` modules, and import / export are converted to cjs compatible ones.
- `src/dh/dhc.getDhc()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find this confusing. Why is the function a bullet point? Why is it calling the function? It seems to break up the paragraph unnecessarily, would just remove the bullet point, have the paragraph go "...running DH Core Server. At runtime ...", then at the end maybe have a link "For implementation details, see ./src/dh/dhc.ts#getDhc" or something like that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

At runtime, `dh-internal.js` and `dh-core.js` are downloaded from the running DH server (default http://localhost:10000). The files are saved to `out/util/tmp` as `.cjs` modules, and import / export are converted to cjs compatible ones.