Fix comments from reviews

packages/dashboard-core-plugins/src/events/index.ts

@@ -1,3 +1,5 @@
+import { type TabEvent as DashboardTabEvent } from '@deephaven/dashboard';
+
 export { default as ChartEvent } from './ChartEvent';
 export { default as ConsoleEvent } from './ConsoleEvent';
 export { default as InputFilterEvent } from './InputFilterEvent';
@@ -6,5 +8,7 @@ export { default as MarkdownEvent } from './MarkdownEvent';
 export { default as NotebookEvent } from './NotebookEvent';
 export { default as PandasEvent } from './PandasEvent';
 
-// Deprecated - use TabEvent from @deephaven/dashboard
-export { type TabEvent } from '@deephaven/dashboard';
+/**
+ * @deprecated Use TabEvent from @deephaven/dashboard
+ */
+export type TabEvent = typeof DashboardTabEvent;

packages/dashboard-core-plugins/src/panels/CorePanel.tsx

@@ -1,6 +1,6 @@
 import React, { PureComponent, type ReactElement } from 'react';
 import { createXComponent } from '@deephaven/components';
-import { type BasePanelProps, Panel } from '@deephaven/dashboard';
+import { type BasePanelProps, BasePanel } from '@deephaven/dashboard';
 import type { dh } from '@deephaven/jsapi-types';
 import { ConsoleEvent, InputFilterEvent } from '../events';
 
@@ -71,7 +71,7 @@ class CorePanel extends PureComponent<CorePanelProps> {
     const { children, ...otherProps } = this.props;
 
     // eslint-disable-next-line react/jsx-props-no-spreading
-    return <Panel {...otherProps}>{children}</Panel>;
+    return <BasePanel {...otherProps}>{children}</BasePanel>;
   }
 }
 

packages/dashboard-core-plugins/src/panels/index.ts

@@ -1,3 +1,5 @@
+import CorePanelImport from './CorePanel';
+
 export { default as ChartPanel } from './ChartPanel';
 export * from './ChartPanel';
 export * from './ChartPanelUtils';
@@ -17,10 +19,13 @@ export { default as MarkdownPanel } from './MarkdownPanel';
 export { default as NotebookPanel } from './NotebookPanel';
 export { default as PandasPanel } from './PandasPanel';
 export * from './PandasPanel';
-export { default as CorePanel } from './CorePanel';
-// Deprecated - use CorePanel instead
-export { default as Panel } from './CorePanel';
 export * from './WidgetPanelTypes';
 export { default as WidgetPanel, type WidgetPanelProps } from './WidgetPanel';
 export { default as WidgetPanelTooltip } from './WidgetPanelTooltip';
 export { default as MockFileStorage } from './MockFileStorage';
+export const CorePanel = CorePanelImport;
+
+/**
+ * @deprecated Use CorePanel instead.
+ */
+export const Panel = CorePanelImport;

packages/dashboard/src/Panel.tsx

@@ -72,7 +72,7 @@ interface PanelState {
 /**
  * Generic panel component that emits mount/unmount/focus events.
  * Also wires up some triggers for common events:
- * Focus, Resize, Show, Session open/close, client disconnect/reconnect.
+ * Focus, Resize, Show
  */
 class Panel extends PureComponent<BasePanelProps, PanelState> {
   constructor(props: BasePanelProps) {

packages/dashboard/src/index.ts

@@ -12,8 +12,12 @@ export { default as DashboardUtils } from './DashboardUtils';
 export * from './LazyDashboard';
 export * from './layout';
 export * from './redux';
-export { type BasePanelProps } from './Panel';
-export { default as Panel } from './Panel';
+export {
+  type BasePanelProps,
+  default as Panel,
+  // Alias for Panel
+  default as BasePanel,
+} from './Panel';
 export * from './PanelManager';
 export * from './PanelEvent';
 export { default as PanelErrorBoundary } from './PanelErrorBoundary';