fix: Remove RefreshBootstrap and refresh token handling (#2257)

- This never worked and doesn't get used anyway, since we attempt re-login with the pre-shared key if provided - Tested by logging into a server with a pre-shared key, then hitting Refresh and ensuring it logged in again without being prompted
deephaven · Oct 23, 2024 · 5686032 · 5686032
1 parent 9d84d8d
commit 5686032
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 128 deletions.
diff --git a/packages/app-utils/src/components/AppBootstrap.test.tsx b/packages/app-utils/src/components/AppBootstrap.test.tsx
@@ -37,7 +37,6 @@ const mockChannel = {
 };
 jest.mock('@deephaven/jsapi-components', () => ({
   ...jest.requireActual('@deephaven/jsapi-components'),
-  RefreshTokenBootstrap: jest.fn(({ children }) => children),
   useBroadcastChannel: jest.fn(() => mockChannel),
   useBroadcastLoginListener: jest.fn(),
 }));

diff --git a/packages/app-utils/src/components/AppBootstrap.tsx b/packages/app-utils/src/components/AppBootstrap.tsx
@@ -3,10 +3,7 @@ import { Provider } from 'react-redux';
 import { store } from '@deephaven/redux';
 import '@deephaven/components/scss/BaseStyleSheet.scss';
 import { ClientBootstrap } from '@deephaven/jsapi-bootstrap';
-import {
-  RefreshTokenBootstrap,
-  useBroadcastLoginListener,
-} from '@deephaven/jsapi-components';
+import { useBroadcastLoginListener } from '@deephaven/jsapi-components';
 import { type Plugin } from '@deephaven/plugin';
 import FontBootstrap from './FontBootstrap';
 import PluginsBootstrap from './PluginsBootstrap';
@@ -70,17 +67,15 @@ export function AppBootstrap({
               options={clientOptions}
               key={logoutCount}
             >
-              <RefreshTokenBootstrap>
-                <AuthBootstrap>
-                  <ServerConfigBootstrap>
-                    <UserBootstrap>
-                      <ConnectionBootstrap>
-                        <FontsLoaded>{children}</FontsLoaded>
-                      </ConnectionBootstrap>
-                    </UserBootstrap>
-                  </ServerConfigBootstrap>
-                </AuthBootstrap>
-              </RefreshTokenBootstrap>
+              <AuthBootstrap>
+                <ServerConfigBootstrap>
+                  <UserBootstrap>
+                    <ConnectionBootstrap>
+                      <FontsLoaded>{children}</FontsLoaded>
+                    </ConnectionBootstrap>
+                  </UserBootstrap>
+                </ServerConfigBootstrap>
+              </AuthBootstrap>
             </ClientBootstrap>
           </ThemeBootstrap>
         </PluginsBootstrap>

diff --git a/packages/jsapi-components/src/RefreshTokenBootstrap.tsx b/packages/jsapi-components/src/RefreshTokenBootstrap.tsx
diff --git a/packages/jsapi-components/src/RefreshTokenUtils.ts b/packages/jsapi-components/src/RefreshTokenUtils.ts
diff --git a/packages/jsapi-components/src/index.ts b/packages/jsapi-components/src/index.ts
@@ -1,7 +1,5 @@
 export * from './HookTestUtils';
 export { default as TableInput } from './TableInput';
-export * from './RefreshTokenBootstrap';
-export * from './RefreshTokenUtils';
 export * from './spectrum';
 export * from './TableDropdown';
 export { default as useBroadcastChannel } from './useBroadcastChannel';