add embed-widget to ci environment

deephaven · Jan 8, 2025 · 5d3167a · 5d3167a
1 parent ce0a9fd
commit 5d3167a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -34,6 +34,7 @@
     "lint:packages": "eslint \"packages/*/src/**/*.{ts,tsx,js,jsx}\"",
     "preview": "lerna run --scope=@deephaven/{code-studio,embed-widget} preview --stream",
     "preview:app": "lerna run --scope=@deephaven/code-studio preview --stream",
+    "preview:embed-widget": "lerna run --scope=@deephaven/embed-widget preview --stream",
     "prestart": "npm run build:necessary",
     "start": "run-p watch:types start:*",
     "start:app": "lerna run start --scope=@deephaven/code-studio --stream",

diff --git a/packages/embed-widget/vite.config.ts b/packages/embed-widget/vite.config.ts
@@ -11,7 +11,7 @@ export default defineConfig(({ mode }) => {
 
   let port = Number.parseInt(env.PORT, 10);
   if (Number.isNaN(port) || port <= 0) {
-    port = 4030;
+    port = 4010;
   }
 
   const baseURL = new URL(env.BASE_URL, `http://localhost:${port}/`);

diff --git a/playwright-ci.config.ts b/playwright-ci.config.ts
@@ -3,14 +3,22 @@ import DefaultConfig from './playwright.config';
 
 const config: PlaywrightTestConfig = {
   ...DefaultConfig,
-  webServer: {
-    // Only start the main code-studio server right now
-    // To test embed-widget, should have an array set for `webServer` and run them all separately as there's a port check
-    command: 'BASE_URL=/ide/ npm run preview:app -- -- -- --no-open', // Passing flags through npm is fun
-    port: 4000,
-    timeout: 60 * 1000,
-    reuseExistingServer: false,
-  },
+  webServer: [
+    {
+      command: 'BASE_URL=/ide/ npm run preview:app -- -- -- --no-open', // Passing flags through npm is fun
+      port: 4000,
+      timeout: 60 * 1000,
+      reuseExistingServer: false,
+    },
+    {
+      command:
+        'BASE_URL=/iframe/widget/ npm run preview:embed-widget -- -- -- --no-open',
+      port: 4010,
+      timeout: 60 * 1000,
+      reuseExistingServer: false,
+    },
+  ],
+
   // Applies to the npm command and CI, but CI will get overwritten in the CI config
   reporter: [['github'], ['html']],
 };

diff --git a/tests/shortcuts.spec.ts b/tests/shortcuts.spec.ts
@@ -12,8 +12,7 @@ test('shortcut downloads logs', async ({ page }) => {
 });
 
 test('shortcut downloads logs in full screen error', async ({ page }) => {
-  // Go to embed-widget page without url parameter to trigger a full screen error
-  await gotoPage(page, 'localhost:4010');
+  await gotoPage(page, 'localhost:4010/iframe/widget');
 
   const downloadPromise = page.waitForEvent('download');
   await page.keyboard.press('ControlOrMeta+Alt+Shift+KeyL');