Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cap width of columns with long names #1574

Merged
merged 4 commits into from
Oct 18, 2023
Merged

fix: cap width of columns with long names #1574

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8088e5
fix: cap width of columns with long names
ethanalvizo Oct 13, 2023
87c402d
PR feedback
ethanalvizo Oct 17, 2023
51614c7
Merge branch 'main' into 1276-truncate-column-name
ethanalvizo Oct 17, 2023
f0628e0
fix accidental removal
ethanalvizo Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grid/src/GridMetricCalculator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,7 +1043,7 @@ export class GridMetricCalculator {
firstColumn,
treePaddingX
);
columnWidths.set(column, columnWidth);
columnWidths.set(column, Math.min(600, columnWidth));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this constant to be defined in the theme so it can be changed manually if needed. Take a look at the calculateColumnWidth method - we already have a minColumnWidth, we could just define a maxColumnWidth that it uses and never go over that.
Note this doesn't address #1284, but that's fine and can be addressed in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take on #1284 after this one. I think it'll be somewhat related anyways

x += columnWidth;
column += 1;
}
Expand Down