Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui plugin prototype w/ spectrum (don't merge) #1575

Closed
wants to merge 9 commits into from

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Oct 13, 2023

  • Externalize iris-grid and chart
  • Add ChartType stuff
  • Add Chart handling of model update
  • Add some more externalized packages
  • Add SpectrumProvider
  • Hopefully this will get me past alpha build failing
  • Add max-old-space-size flag to embed-chart
  • Externalize Log
  • Fix up the dark theme

- Needed for chart plugins to work
- Now styles Spectrum components more or less correctly
- Instead of building apps in parallel build at the same time
- Currently getting an OoM error when building in GitHub publish alpha action
- It was only in code-studio and embed-grid for some reason
@github-actions
Copy link
Contributor

Pull Request titles must follow the Conventional Commits specification.

Details:

No release type found in pull request title "ui plugin prototype w/ spectrum (don't merge)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d796f83) 46.42% compared to head (6ced152) 46.45%.
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
+ Coverage   46.42%   46.45%   +0.02%     
==========================================
  Files         558      571      +13     
  Lines       35714    36032     +318     
  Branches     8916     9021     +105     
==========================================
+ Hits        16582    16738     +156     
- Misses      19082    19242     +160     
- Partials       50       52       +2     
Flag Coverage Δ
unit 46.45% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/app-utils/src/plugins/remote-component.config.ts 100.00% <ø> (ø)
packages/code-studio/src/AppRoot.tsx 0.00% <0.00%> (ø)
packages/chart/src/Chart.tsx 0.00% <0.00%> (ø)

... and 77 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed closed this Oct 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant