feat: Theming - Spectrum Provider #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
+ Coverage 46.65% 46.72% +0.07%
==========================================
Files 575 581 +6
Lines 36189 36263 +74
Branches 9063 9074 +11
==========================================
+ Hits 16883 16944 +61
- Misses 19254 19267 +13
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
- Pinning to 1.37.1 - Firefox pointer fixes
bmingles
force-pushed
the
1543-theming-spectrum-provider
branch
from
ba94735 to
8537f41
Compare
mofojed
approved these changes
Oct 24, 2023
| // 120px. CSS uses this to only show the button when the user has scrolled. | ||
| useEffect(() => { | ||
| function onScroll() { | ||
| document.documentElement.dataset.scroll = String(window.scrollY > 120); |
There was a problem hiding this comment.
Why 120px? Name the constant to give it some more context.
There was a problem hiding this comment.
It's arbitrary. It just "felt" right. I'll name it in next PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
'(any-pointer: fine)'media queriesresolves #1543