style: Enable method-signature-style TypeScript ESLint rule #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 1578-eslint-method-signature
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
=======================================
Coverage 46.74% 46.74%
=======================================
Files 583 583
Lines 36256 36256
Branches 9072 9072
=======================================
Hits 16947 16947
Misses 19257 19257
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Oct 23, 2023
packages/iris-grid/src/sidebar/visibility-ordering-builder/VisibilityOrderingItem.tsx
Outdated
Show resolved
Hide resolved
packages/iris-grid/src/sidebar/visibility-ordering-builder/sortable-tree/SortableTree.tsx
Outdated
Show resolved
Hide resolved
packages/iris-grid/src/sidebar/visibility-ordering-builder/sortable-tree/SortableTreeInner.tsx
Outdated
Show resolved
Hide resolved
georgecwan
force-pushed
the
1578-eslint-method-signature
branch
from
d8a923a to
3d93c0f
Compare
georgecwan
force-pushed
the
1578-eslint-method-signature
branch
from
3d93c0f to
7e2ce8d
Compare
mattrunyon
requested changes
Oct 25, 2023
packages/iris-grid/src/AdvancedFilterCreatorSelectValueList.tsx
Outdated
Show resolved
Hide resolved
georgecwan
force-pushed
the
1578-eslint-method-signature
branch
from
e8aee14 to
24edf02
Compare
mattrunyon
approved these changes
Oct 26, 2023
|
Good work! Looks like this caught a few places where our types weren't quite correct and we could have potentially done something not safe in the future |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method-signature-style rule to ESLint rules with default
propertymode.Resolves #1578