Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panels not reinitializing if makeModel changes #1633

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

mattrunyon
Copy link
Collaborator

Mostly needed for Deephaven UI w/ widget plugin loading which will recreate the makeModel method if a new widget is created

@mattrunyon mattrunyon requested a review from mofojed November 9, 2023 22:59
@mattrunyon mattrunyon self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (52ba2cd) 46.63% compared to head (29f98e9) 46.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
+ Coverage   46.63%   46.65%   +0.01%     
==========================================
  Files         591      591              
  Lines       36406    36406              
  Branches     9113     9116       +3     
==========================================
+ Hits        16979    16984       +5     
+ Misses      19375    19370       -5     
  Partials       52       52              
Flag Coverage Δ
unit 46.65% <21.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/app-utils/src/plugins/remote-component.config.ts 100.00% <ø> (ø)
...shboard-core-plugins/src/panels/ChartPanelUtils.ts 33.33% <100.00%> (+13.33%) ⬆️
...ckages/dashboard-core-plugins/src/panels/Panel.tsx 69.67% <ø> (ø)
...ashboard-core-plugins/src/panels/IrisGridPanel.tsx 43.24% <75.00%> (+0.19%) ⬆️
packages/dashboard-core-plugins/src/GridPlugin.tsx 33.33% <0.00%> (+8.33%) ⬆️
...ckages/dashboard-core-plugins/src/PandasPlugin.tsx 33.33% <0.00%> (+8.33%) ⬆️
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 61.40% <57.14%> (-0.32%) ⬇️
...kages/dashboard-core-plugins/src/useHydrateGrid.ts 0.00% <0.00%> (ø)
...ackages/dashboard-core-plugins/src/ChartPlugin.tsx 3.77% <0.00%> (-0.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit 5ee98cd into deephaven:main Nov 10, 2023
@mattrunyon mattrunyon deleted the ui-panel-fixes branch November 10, 2023 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants