Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added shortcut for copying version info and added browser/os to info #1739

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: added shortcut for copying version info and added browser/os to info #1739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98dd9ec
feat: added shortcut for copying version info and added browser/os to…
dsmmcken Jan 19, 2024
f6c0555
review feedback
dsmmcken Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/code-studio/src/settings/SettingsUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,18 @@ export function getFormattedVersionInfo(
serverConfigValues: ServerConfigValues
): Record<string, string> {
const ua = Bowser.parse(window.navigator.userAgent);
const browser = `${(ua.browser.name ?? '') || 'Unknown'} ${
// use only the major version and minor version, rest usually empty 120.1.0.0 -> 120.1
const browser = `${ua.browser.name ?? ''} ${
// use only the major version and minor version, rest is usually empty 120.1.0.0 -> 120.1
Number(parseFloat(ua.browser.version ?? '')) || ''
dsmmcken marked this conversation as resolved.
Show resolved Hide resolved
}`;
const os = `${(ua.os.name ?? '') || 'Unknown'} ${ua.os.version ?? ''}`;
const os = `${ua.os.name ?? ''} ${ua.os.version ?? ''}`;
return {
'Engine Version': serverConfigValues.get('deephaven.version') ?? 'Unknown',
'Web UI Version': import.meta.env.npm_package_version ?? 'Unknown',
'Java Version': serverConfigValues.get('java.version') ?? 'Unknown',
'Barrage Version': serverConfigValues.get('barrage.version') ?? 'Unknown',
'Browser Name': browser.trim(),
'OS Name': os.trim(),
'Browser Name': browser.trim() || 'Unknown',
'OS Name': os.trim() || 'Unknown',
};
}

Expand Down
Loading