Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Panel into @deephaven/dashboard #2304

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Fix comments from reviews

0e17d8e
Select commit
Loading
Failed to load commit list.
Open

refactor: Move Panel into @deephaven/dashboard #2304

Fix comments from reviews
0e17d8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 29, 2025 in 0s

46.69% (-0.08%) compared to d1e345a

View this Pull Request on Codecov

46.69% (-0.08%) compared to d1e345a

Details

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 46.69%. Comparing base (d1e345a) to head (0e17d8e).

Files with missing lines Patch % Lines
...es/dashboard-core-plugins/src/panels/CorePanel.tsx 67.85% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2304      +/-   ##
==========================================
- Coverage   46.76%   46.69%   -0.08%     
==========================================
  Files         710      712       +2     
  Lines       39107    39119      +12     
  Branches     9958     9773     -185     
==========================================
- Hits        18288    18266      -22     
- Misses      20765    20842      +77     
+ Partials       54       11      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.