-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: No context menu item for paste in an input table #2341
Open
ericlln
wants to merge
13
commits into
deephaven:main
Choose a base branch
from
ericlln:DH-18358-no-context-menu-item-for-paste-in-an-input-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: No context menu item for paste in an input table #2341
ericlln
wants to merge
13
commits into
deephaven:main
from
ericlln:DH-18358-no-context-menu-item-for-paste-in-an-input-table
+284
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works now but need to revisit how and why
…paste-in-an-input-table
…paste-in-an-input-table
is there any documentation on this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
+ Coverage 46.70% 46.71% +0.01%
==========================================
Files 704 706 +2
Lines 39044 39084 +40
Branches 9757 9950 +193
==========================================
+ Hits 18234 18260 +26
- Misses 20799 20813 +14
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clipboard-read
permission (e.g. Chrome), clicking paste results in the same behaviour as pressing the keyboard shortcut, provided the user has accepted the request for permissionclipboard-read
permission (e.g. Firefox and Safari), a modal is shown to explain the reason and to suggest using the keyboard shortcut insteadAdditional related issues fixed
instead of
which we were expecting before. Was able to reproduce former behaviour on an older build of Firefox (91.0), meaning this discrepancy is likely caused by an update to Firefox (unsure when exactly)