Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monaco editor overflowing at certain zoom levels #2346

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Jan 22, 2025

Container has 1462.86px of space but Monaco is setting itself to 1463px, causing overflow.

May have to play with zoom levels and browser widths to get it to reproduce. For me a 2560 window with 2 levels of zoom reliably reproduced.

image

Fix by overriding those widths to be 100%. Noticed no behavior differences other than fixing zoom issue.

@dsmmcken dsmmcken requested a review from mofojed January 22, 2025 15:39
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.74%. Comparing base (5f6c8d6) to head (b58b9a3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
+ Coverage   46.70%   46.74%   +0.04%     
==========================================
  Files         704      705       +1     
  Lines       39044    39054      +10     
  Branches     9757     9947     +190     
==========================================
+ Hits        18234    18256      +22     
+ Misses      20799    20744      -55     
- Partials       11       54      +43     
Flag Coverage Δ
unit 46.74% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken enabled auto-merge (squash) January 22, 2025 16:04
@dsmmcken dsmmcken merged commit bbba404 into main Jan 22, 2025
12 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_fix_zoom_overflow branch January 22, 2025 22:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants