-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial directives #195
Merged
Merged
Tutorial directives #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLKRo
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Aug 10, 2023
pseusys
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also like to see documentation linking implementation here.
Also, add newline matching, set pip to quiet.
pseusys
approved these changes
Aug 16, 2023
kudep
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two tutorial directives (one for inserting installation cells, and one for inserting documentation links).
Tutorial dependencies separated from test dependencies in
setup.py
.Also, added a test to ensure that all dependencies listed in tutorials are correct
(the test is currently disabled in all workflows since is takes ~2 minutes to complete).Removed most of other(returned because coverage)test_tutorials
tests since this one covers them.I'm currently considering removing the test and instead converting tutorials to notebooks (and running them) inside isolated venvs (and using converted notebooks in documentation).
Checklist