Reduce max line length for tutorials #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tutorials/script/core/7_pre_response_processing.py
Flake was also complaining about the length of comments and strings which are displayed properly in the docs. And blake is enough to ensure that code fits in the docs. Line limit decreased because some strings were still not fitting. And also `flake: noqa: E402` doesn't work -- that line disables all quality assurance for that file so instead `per-file-ignores` are added.
RLKRo
added a commit
that referenced
this pull request
Nov 21, 2023
Release v0.6.3 # Release notes - Update README to make it more concise and include reasons to use DFF (#281) - Add [DFF optimization guide](https://deeppavlov.github.io/dialog_flow_framework/user_guides/optimization_guide.html) (#236) - Add documentation section description for the [index page](https://deeppavlov.github.io/dialog_flow_framework/index.html) (#281) - Add async method [dff.messengers.common.interface.CallbackMessengerInterface.on_request_async](https://deeppavlov.github.io/dialog_flow_framework/apiref/dff.messengers.common.interface.html#dff.messengers.common.interface.CallbackMessengerInterface.on_request_async) (#206) - Move information about messenger interfaces from `pipeline.6_custom_messenger_interface` (removed) to [messengers.web_api_interface.1_fastapi](https://deeppavlov.github.io/dialog_flow_framework/tutorials/tutorials.messengers.web_api_interface.1_fastapi.html) (#206) - Fix cross-references in [dff.messengers.common.interface](https://deeppavlov.github.io/dialog_flow_framework/apiref/dff.messengers.common.interface.html) (#206) - Update tutorials to fit into documentation without side-scrolling (#241)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code from tutorials often doesn't fit inside the generated codeblocks and users have to scroll in order to read them.
This PR reduces
max-line-lengthfor tutorial files.Max line length for flake8 is not reduced because it also complains about strings and comments exceeding max line length. But I did go through every line it complained (with lowered line length) and ensured that it was ok not to fix them.
Also, a bit out of scope of this PR but it got in my way so this PR fixes an issue with flake completely ignoring many files by adding
per-file-ignoresinstead offlake8: noqa.Checklist