Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker volumes #270

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add docker volumes #270

merged 2 commits into from
Nov 8, 2023

Conversation

RLKRo
Copy link
Member

@RLKRo RLKRo commented Nov 7, 2023

Description

Add docker volumes for context storages to persist contexts after docker restart.

Adding tests for that would be difficult (due to the need to restart containers) but I tested that it works in codespaces and locally.

Although locally I have an issue with running ydb after adding volumes:

dff-ydb-1    | Caught exception: (No such file or directory) util/system/file.cpp:857: can't open "/ydb_certs/ca.pem" with mode RdOnly|Seq (0x00000028)

The issue is not present in codespaces (possibly due to clean environment).

UPD: removing ydb volumes and images and running again solves the issue.

Also, this PR removes names for stats volumes (I don't understand why we need them).

Checklist

  • I have covered the code with tests
  • I have added comments to my code to help others understand it
  • I have updated the documentation to reflect the changes
  • I have performed a self-review of the changes

@RLKRo RLKRo added the enhancement New feature or request label Nov 7, 2023
@RLKRo RLKRo self-assigned this Nov 7, 2023
@RLKRo RLKRo requested a review from ruthenian8 November 8, 2023 18:27
@RLKRo RLKRo merged commit a246c56 into dev Nov 8, 2023
16 checks passed
@RLKRo RLKRo deleted the feat/docker-volumes branch November 8, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants