-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for handling non-Latin characters #7
base: master
Are you sure you want to change the base?
Conversation
This change introduces support for text containing non-Latin characters (Hindi, Urdu, Greek, for example). This is done by printing `html.unescape(final_string)` instead of `final_string`.
@deepseagirl could you merge this after review? |
@deepseagirl hi, just sending a ping on this. thanks! |
@deepseagirl Can we close this? |
hi, thanks. this is a good improvement :) new default will be to decode character references:
flag to turn decoding off:
the html.unescape python doc links to this list of named character references which seemed handy. |
i'll finalize this when i have a few more mins. should be soon now that it's this far along. thanks again |
@deepseagirl no worries, and I realize you were not able to access a computer earlier, so it is no problem. the new changes look great! thank you & tc =) |
@deepseagirl can we close? |
This change introduces support for search results containing non-Latin characters as part of the URL or description.
This is done by passing the
final_string
variable to thehtml.unescape()
function (instead of printing it directly) at the lastprint
call.