feat: tests on PR & push to main #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArzelaAscoIi
commented
Dec 9, 2024
| @@ -44,7 +44,7 @@ detached = true | |||
| [tool.hatch.envs.dc.scripts] | |||
| build = "mkdir -p dist && zip -r dist/custom_component.zip ./* -x 'dist/*' '**/__pycache__/*'" | |||
| push = "curl --request POST --url https://api.cloud.deepset.ai/api/v2/custom_components --header 'accept: application/json' --header \"Authorization: Bearer $API_KEY\" --form 'file=@dist/custom_component.zip;type=application/zip'" | |||
| build-and-push = "mkdir -p dist && zip -r dist/custom_component.zip ./* -x 'dist/*' '**/__pycache__/*' && curl --request POST --url https://api.cloud.deepset.ai/api/v2/custom_components --header 'accept: application/json' --header \"Authorization: Bearer $API_KEY\" --form 'file=@dist/custom_component.zip;type=application/zip'" | |||
| build-and-push = "hatch run code-quality:all && mkdir -p dist && zip -r dist/custom_component.zip ./* -x 'dist/*' '**/__pycache__/*' && curl --request POST --url https://api.cloud.deepset.ai/api/v2/custom_components --header 'accept: application/json' --header \"Authorization: Bearer $API_KEY\" --form 'file=@dist/custom_component.zip;type=application/zip'" | |||
There was a problem hiding this comment.
thats a bit drastic, but it should help us fixing bugs in dC
faymarie
reviewed
Dec 9, 2024
pyproject.toml
Outdated
| @@ -63,6 +63,13 @@ dependencies = [ | |||
| packages = ["src/dc_custom_component"] | |||
|
|
|||
| [tool.hatch.envs.code-quality.scripts] | |||
| format = "black src tests --check" | |||
| format-fix = "black src tests" | |||
| lint = "ruff ." | |||
There was a problem hiding this comment.
I believe it was changed to ruff check .
Suggested change
| lint = "ruff ." | |
| lint = "ruff check ." |
There was a problem hiding this comment.
thats the lint-ci command below 🙈
There was a problem hiding this comment.
Don't we usually do ruff check --output-format=github for the lint-ci command?
There was a problem hiding this comment.
oh damn. you are right. it should also be ruff check . (--fix). What i used is deprecated
faymarie
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case you are trying to push a component that fails linting:
