Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Google Vertex Chat Generator compatible with new ChatMessage #1255

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: make Google Vertex Chat Generator compatible with new ChatMessage #1255

merged 2 commits into from
Dec 19, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • small fixes to ensure that the Google Vertex Chat Generator is compatible with both old and new ChatMessage

How did you test it?

CI; local tests with Haystack main branch

Checklist

@anakin87 anakin87 marked this pull request as ready for review December 18, 2024 16:45
@anakin87 anakin87 requested a review from a team as a code owner December 18, 2024 16:45
@anakin87 anakin87 requested review from vblagoje and removed request for a team December 18, 2024 16:45
@anakin87 anakin87 merged commit 07ca7a6 into main Dec 19, 2024
16 checks passed
@anakin87 anakin87 deleted the fix-vertex-new-chat-message branch December 19, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
integration:google-vertex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @vblagoje