Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update OpenAPITool tests #105

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Sep 26, 2024

  • adds skipif marker to test_allowed_operations unit test (fork repo sensitive test)
  • mark test_run_live_meteo_forecast_with_non_normalized_operation_id as unstable as meteo service can be often down

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11055672814

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 90.082%

Files with Coverage Reduction New Missed Lines %
components/tools/openapi/_schema_conversion.py 3 88.79%
Totals Coverage Status
Change from base Build 11049067911: -0.2%
Covered Lines: 1426
Relevant Lines: 1583

💛 - Coveralls

@vblagoje vblagoje changed the title draft: Update OpenAPITool tests chore: Update OpenAPITool tests Sep 26, 2024
@vblagoje vblagoje marked this pull request as ready for review September 26, 2024 15:42
@vblagoje vblagoje requested a review from a team as a code owner September 26, 2024 15:42
@vblagoje vblagoje requested review from anakin87 and shadeMe and removed request for a team September 26, 2024 15:42
@vblagoje
Copy link
Member Author

@shadeMe @anakin87 This PR is intentionally coming from forked repo to test newly surfaced test failures described above

@anakin87
Copy link
Member

Just an observation: while working on #102, I noticed that unstable tests are never executed and kept this behavior.

@vblagoje
Copy link
Member Author

Just an observation: while working on #102, I noticed that unstable tests are never executed and kept this behavior.

Yes, the idea (Madeesh and I talked about it) was - don't execute unstable tests on CI, but execute them locally. I'll revisit these tests as soon as I'm done with this Hackathon prep.

@vblagoje vblagoje merged commit 186536b into deepset-ai:main Sep 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants