Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding forward references for integration generations in LLMMetadataExtractor #110

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: adding forward references for integration generations in LLMMetadataExtractor #110

merged 1 commit into from
Oct 1, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Oct 1, 2024 •
edited by anakin87
Loading

fixes #109

Checklist

@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11128858682

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.558%
Totals Coverage Status
Change from base Build 11105076260: 0.0%
Covered Lines: 1486
Relevant Lines: 1678
💛 - Coveralls

@davidsbatista davidsbatista marked this pull request as ready for review October 1, 2024 15:46
@davidsbatista davidsbatista requested a review from a team as a code owner October 1, 2024 15:46
@davidsbatista davidsbatista requested review from vblagoje and anakin87 and removed request for a team October 1, 2024 15:46
anakin87
anakin87 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidsbatista davidsbatista merged commit 3c834bb into main Oct 1, 2024
15 checks passed
@davidsbatista davidsbatista deleted the adding-forward-references-llm-metadataextractor branch October 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AmazonBedrockGenerator is not imported lazily
3 participants
@davidsbatista @coveralls @anakin87