feat: make Tool.from_function more configurable
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
commented
Dec 12, 2024
| @@ -106,7 +106,7 @@ def from_dict(cls, data: Dict[str, Any]) -> "Tool": | |||
| return cls(**data) | |||
|
|
|||
| @classmethod | |||
| def from_function(cls, function: Callable, docstring_as_desc: bool = True) -> "Tool": | |||
There was a problem hiding this comment.
I've decided to remove docstring_as_desc since the new parameters allow for more configurability.
We can do that because we are in experimental.
Pull Request Test Coverage Report for Build 12354141486Details
💛 - Coveralls |
julian-risch
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Looks quite good to me already. The new description that defaults to the docstring is a nice simplification compared to the previous docstring_as_desc.
I have one suggestion to simplify one of the test cases. Let me know what you think and if you see any reason to keep that test case as is. Otherwise the PR is ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
nameanddescriptionconfigurable inTool.from_functionhaystack#8629Proposed Changes:
nameanddescriptioninTool.from_functionclass methodHow did you test it?
CI, adapted tests and new tests
Notes for the reviewer
Unit tests are failing for reasons unrelated to this PR. I'm trying to fix them in #156
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.