Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make tests for ChatMessage retriever and writer compatible with the new API #163

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 7, 2025

Related Issues

Proposed Changes:

Small test adaptations for making the tests of ChatMessage retriever and writer compatible with both new and old API

How did you test it?

CI; local test with Haystack main

Checklist

@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12654519488

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.128%

Totals Coverage Status
Change from base Build 12642587581: 0.0%
Covered Lines: 2025
Relevant Lines: 2436

💛 - Coveralls

@anakin87 anakin87 changed the title chore: make ChatMessage retriever and writer compatible with the new API chore: make tests for ChatMessage retriever and writer compatible with the new API Jan 7, 2025
@anakin87 anakin87 marked this pull request as ready for review January 7, 2025 15:46
@anakin87 anakin87 requested a review from a team as a code owner January 7, 2025 15:46
@anakin87 anakin87 requested review from vblagoje and removed request for a team January 7, 2025 15:46
@anakin87 anakin87 merged commit 41903c1 into main Jan 8, 2025
15 checks passed
@anakin87 anakin87 deleted the chatmessage-retriever-writer-adaptations branch January 8, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants