feat: pending registry commands #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRT-151 Add missing EboRegistry commands
When refactoring the Two commands were already implemented, we need to complete those commands to cover actor's handling for the following three events:
AC:
|
Base automatically changed from
feat/actor-as-event-queues
to
feat/processor-start
September 3, 2024 20:05
0xyaco
force-pushed
the
feat/registry-commands
branch
from
f661d4e to
a32ec9b
Compare
0xyaco
force-pushed
the
feat/registry-commands
branch
from
a32ec9b to
93d1461
Compare
0xnigir1
approved these changes
Sep 3, 2024
0xkenj1
reviewed
Sep 4, 2024
| @@ -378,9 +399,6 @@ export class EboActor { | |||
| * @param event `RequestCreated` event | |||
| */ | |||
| public async onRequestCreated(event: EboEvent<"RequestCreated">): Promise<void> { | |||
| if (event.metadata.requestId != this.actorRequest.id) | |||
| throw new RequestMismatch(this.actorRequest.id, event.metadata.requestId); | |||
|
|
|||
There was a problem hiding this comment.
not sure why are we skiping this validation.
0xkenj1
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-151
Description
EboRegistrycommandsResponseDisputed→AddDisputecommandDisputeStatusChanged→UpdateDisputeStatuscommandRequestFinalized→Noopcommand